ongdisheng commented on PR #705: URL: https://github.com/apache/fesod/pull/705#issuecomment-3571791729
Hi @GOODBOY008, thank you for working on this optimization! I do agree that the `paths-ignore` approach is simpler and easier to maintain for future changes. However, I noticed it would still trigger CI for several configuration files in our current repository 1. Configuration files: .asf.yaml, .gitignore, licenserc.toml, lombok.config, logo.svg 2. GitHub files: .github/dependabot.yml, .github/ISSUE_TEMPLATE/*.yml 3. Other workflow files: .github/workflows/deploy-docs.yml, markdownlint.yml, etc. 4. Tools: tools/spotless/license-header.txt, mvnw, mvnw.cmd That's about 20+ files that would still run Java CI builds unnecessarily while the include approach ensures CI only runs for actual code and build changes. I think both approaches have their own trade-offs. Feel free to let me know what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
