ongdisheng commented on issue #703: URL: https://github.com/apache/fesod/issues/703#issuecomment-3589750412
Hi @delei, I noticed the `markdownlint` step in `ci-docs` which was taken from the previous `markdownlint.yml` workflow seems to have an issue as it appears to be failing to detect changed files as shown in [1](https://github.com/apache/fesod/actions/runs/19613396580/job/56162497252?pr=709) and [2](https://github.com/apache/fesod/actions/runs/19669152069/job/56333416231): ```bash fatal: ambiguous argument 'origin/main...feature/test_preview_20251123': unknown revision or path not in the working tree. No markdown files changed, skipping lint. ``` It looks like the bash script might not be able to find the git reference in some cases, causing the linting to be skipped even when there are markdown changes. I was wondering if we could consider using GitHub Actions instead: - [ana06/get-changed-files](https://github.com/Ana06/get-changed-files): Gets changed markdown files - [DavidAnson/markdownlint-cli2-action](https://github.com/DavidAnson/markdownlint-cli2-action): Lints those files This might be simpler and could work more consistently. I've tested it in my repo [link](https://github.com/ongdisheng/fesod/pull/4) and it seems to work well. Just wondering what's your take on this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
