Copilot commented on code in PR #768:
URL: https://github.com/apache/fesod/pull/768#discussion_r2649674649
##########
fesod-sheet/src/test/resources/logback.xml:
##########
@@ -20,7 +20,7 @@
-->
<configuration>
- <include resource="org/springframework/boot/logging/logback/defaults.xml"/>
+ <property name="CONSOLE_LOG_PATTERN" value="%d{HH:mm:ss.SSS} [%thread]
%-5level %logger{36} - %msg%n"/>
Review Comment:
The fix to remove the Spring Boot specific include for logback defaults is
incomplete. While this file has been corrected to use a standard property
definition, the file
fesod-examples/fesod-sheet-examples/src/test/resources/logback.xml still
contains the same problematic Spring Boot include. This should be updated
consistently across all modules to avoid the same parsing errors in the
examples module.
##########
pom.xml:
##########
@@ -75,10 +75,9 @@
<spring-core.version>5.3.39</spring-core.version>
<fastjson2.version>2.0.60</fastjson2.version>
<spring-boot-starter-web.version>2.7.18</spring-boot-starter-web.version>
- <slf4j-simple.version>1.7.36</slf4j-simple.version>
<jcl-over-slf4j.version>1.7.36</jcl-over-slf4j.version>
<log4j-over-slf4j.version>1.7.36</log4j-over-slf4j.version>
Review Comment:
The logback-classic version has been downgraded from 1.5.23 to 1.2.13. While
this older version is compatible with SLF4J 1.7.36, the downgrade should be
justified. Version 1.5.x is a significant upgrade with improvements and bug
fixes. Consider documenting the reason for this downgrade or using a newer
compatible version like 1.4.x series if there are specific compatibility
requirements.
```suggestion
<log4j-over-slf4j.version>1.7.36</log4j-over-slf4j.version>
<!--
NOTE: logback-classic 1.4.x/1.5.x require SLF4J 2.x. This
project currently uses SLF4J 1.7.36
and Spring Boot 2.7.x, which are aligned with the Logback 1.2.x
line. We intentionally pin
logback-classic to 1.2.13 for compatibility, despite it being
older than the 1.5.x series.
-->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
