pjfanning commented on code in PR #780: URL: https://github.com/apache/fesod/pull/780#discussion_r2668576471
########## dist/licenses/LICENSE-spring-core.txt: ########## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 + https://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by Review Comment: * let me look into this - there is no guarantee that spring-core is correct * these classes that we are taking from spring-core come from cglib and asm and we at least also have their licenses too. * since this license is just a generic Apache license, I would prefer to put a single LICENSE and NOTICE into META-INF that is basically the Fesod license and notice with additional text saying we also have Apache licensed classes from spring-core - so no spring license, just a modified Fesod license/notice that mentions spring-core and ideally the affected shaded package names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
