bengbengbalabalabeng commented on issue #788: URL: https://github.com/apache/fesod/issues/788#issuecomment-3731790677
We can consider applying stricter encapsulation to the two Map fields `hasBeenInitializedSheetIndexMap` and `hasBeenInitializedSheetNameMap`. The proposed approach is as follows: 1. Disable the setter methods to prevent replacing the entire Map. 2. Make the getter methods return immutable Maps to avoid external modifications such as `get***Map().put()`. 3. Introduce dedicated `add` methods as the only entry point for updates, with built‑in null checks for both key and value, throwing an exception when violated (fail-fast). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
