GOODBOY008 opened a new pull request, #819:
URL: https://github.com/apache/fesod/pull/819
## Summary
This PR removes duplicate utility classes from the `fesod-sheet` module that
already exist in the `fesod-common` module, eliminating code duplication and
establishing `fesod-common` as the single source of truth for shared utilities.
## Changes
- **Deleted 8 duplicate classes** from
`fesod-sheet/src/main/java/org/apache/fesod/sheet/util/`:
- BooleanUtils.java
- IntUtils.java
- IoUtils.java
- ListUtils.java
- MapUtils.java
- MemberUtils.java
- PositionUtils.java
- StringUtils.java
- **Updated ~100 files** to import from `org.apache.fesod.common.util.*`
instead of `org.apache.fesod.sheet.util.*`
- **Fixed method name typo**: `getRowByRowTagt()` → `getRowByRowTag()` in
`RowTagHandler.java`
- **Added necessary imports** to remaining sheet-specific util classes
(ClassUtils, DateUtils, FieldUtils, etc.)
## Motivation
Having duplicate utility classes across modules is a code smell that leads
to:
- Maintenance burden (changes must be synced)
- Potential inconsistencies
- Larger codebase than necessary
## Test Plan
- ✅ Build succeeds: `mvn clean compile -DskipTests`
- ✅ All imports resolved correctly
- ✅ No breaking changes to public API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
