skytin1004 opened a new pull request, #911:
URL: https://github.com/apache/fesod/pull/911

   ## Purpose of the pull request
   
   Part of #889.
   
   This PR focuses only on the recursive holder/context `hashCode()` path.
   
   It intentionally does not change converter lookup behavior. The converter 
lookup behavior will be handled separately because it can fail independently 
when a global converter is registered with a non-null `supportExcelTypeKey()`.
   
   ## What's changed?
   
   - Exclude `workbookWriteHandlerContext` from `WriteWorkbookHolder` 
equality/hashCode generation.
   - Exclude parent/cache holder references from `WriteSheetHolder` and 
`WriteTableHolder` equality/hashCode generation.
   - Add a focused regression test for the recursive workbook handler context 
path and the initialized workbook/sheet/table holder graph.
   
   ## Verification
   
   ```bash
   bash mvnw -pl fesod-common,fesod-shaded -am -DskipTests install
   bash mvnw -pl fesod-sheet -Dtest=WriteHolderHashCodeTest,CustomConverterTest 
-Dmaven.test.skip=false test
   bash mvnw -pl fesod-sheet -Dmaven.test.skip=false test
   ```
   
   ## Checklist
   
   - [x] I have read the [Contributor 
Guide](https://fesod.apache.org/community/contribution/).
   - [x] I have written the necessary doc or comment.
   - [x] I have added the necessary unit tests and all cases have passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to