bengbengbalabalabeng commented on code in PR #942:
URL: https://github.com/apache/fesod/pull/942#discussion_r3594885838
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandler.java:
##########
@@ -81,6 +82,25 @@ public void startElement(XlsxReadContext xlsxReadContext,
String name, Attribute
public void endElement(XlsxReadContext xlsxReadContext, String name) {
XlsxReadSheetHolder xlsxReadSheetHolder =
xlsxReadContext.xlsxReadSheetHolder();
ReadCellData<?> tempCellData = xlsxReadSheetHolder.getTempCellData();
+ int targetColumnIndex = 0;
+
+ List<Integer> includeColumnIndexes = null;
+ includeColumnIndexes =
xlsxReadContext.readSheetHolder().getReadSheet().getColumnIndexes();
Review Comment:
The initial assignment `null` is redundant.
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandler.java:
##########
@@ -81,6 +82,25 @@ public void startElement(XlsxReadContext xlsxReadContext,
String name, Attribute
public void endElement(XlsxReadContext xlsxReadContext, String name) {
XlsxReadSheetHolder xlsxReadSheetHolder =
xlsxReadContext.xlsxReadSheetHolder();
ReadCellData<?> tempCellData = xlsxReadSheetHolder.getTempCellData();
+ int targetColumnIndex = 0;
+
+ List<Integer> includeColumnIndexes = null;
+ includeColumnIndexes =
xlsxReadContext.readSheetHolder().getReadSheet().getColumnIndexes();
+
+ if (includeColumnIndexes == null) {
+ targetColumnIndex = xlsxReadSheetHolder.getColumnIndex();
+ //
xlsxReadSheetHolder.getCellMap().put(xlsxReadSheetHolder.getColumnIndex(),
tempCellData);
Review Comment:
The commented-out code can be removed to keep the implementation clean and
avoid confusion. (Similarly, line 98)
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandler.java:
##########
@@ -81,6 +82,25 @@ public void startElement(XlsxReadContext xlsxReadContext,
String name, Attribute
public void endElement(XlsxReadContext xlsxReadContext, String name) {
XlsxReadSheetHolder xlsxReadSheetHolder =
xlsxReadContext.xlsxReadSheetHolder();
ReadCellData<?> tempCellData = xlsxReadSheetHolder.getTempCellData();
+ int targetColumnIndex = 0;
+
+ List<Integer> includeColumnIndexes = null;
+ includeColumnIndexes =
xlsxReadContext.readSheetHolder().getReadSheet().getColumnIndexes();
+
+ if (includeColumnIndexes == null) {
+ targetColumnIndex = xlsxReadSheetHolder.getColumnIndex();
+ //
xlsxReadSheetHolder.getCellMap().put(xlsxReadSheetHolder.getColumnIndex(),
tempCellData);
+ } else {
+ targetColumnIndex =
includeColumnIndexes.indexOf(xlsxReadSheetHolder.getColumnIndex());
+ if (targetColumnIndex != -1) {
+ // If it's a target column, rewrite the cell's internal index
and pack it sequentially
+ tempCellData.setColumnIndex(targetColumnIndex);
Review Comment:
The `setColumnIndex` assignment here is always overwritten by the one at
line 155. Please confirm what the final `tempCellData#columnIndex` is expected
to represent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
