bengbengbalabalabeng commented on issue #955:
URL: https://github.com/apache/fesod/issues/955#issuecomment-5031607021
Based on my understanding, if explicit validation of unknown t attribute is
performed in the method `CellDataTypeEnum.buildFromCellType` and a clearer
exception is thrown (e.g., `throw new IllegalArgumentException("Invalid cell
data type: xxx")`), it would be more consistent with the fast-fail processing
logic.
The reason for using `IllegalArgumentException` is that this is not a
logical exception in the parsing flow; treating it as an argument error is more
semantically appropriate here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
