SyedIshmumAhnaf opened a new pull request, #1019:
URL: https://github.com/apache/fesod/pull/1019
## Purpose of the pull request
Related: #1017
Add first-class converter support for `java.sql.Timestamp`, following the
existing temporal converter patterns in Apache Fesod.
## What's changed?
- Added `TimestampDateConverter` as the default write converter for
`Timestamp`.
- Added `TimestampNumberConverter` for Excel numeric date conversion,
including `use1904windowing` handling.
- Added `TimestampStringConverter` using the existing `DateUtils`
parsing/formatting behavior and `@DateTimeFormat` support.
- Registered the new converters in `DefaultConverterLoader` using the same
read/write structure as `LocalDateTime`.
- Added `TimestampConverterTest` covering:
- converter support keys
- number read/write behavior
- 1904 date windowing
- string parsing/formatting
- custom date-time format handling
- date write behavior
- default converter registration
The change is intentionally scoped to `java.sql.Timestamp` and does not
modify the converter lookup mechanism or other converter types.
Verification:
- `./mvnw spotless:check`
- `./mvnw -pl fesod-sheet -Dmaven.test.skip=false
-Dtest=TimestampConverterTest,ConverterTest,ConverterDataTest,CustomConverterTest
test`
- 68 tests passed
- CI-equivalent module build with tests enabled passed successfully.
## Checklist
- [x] I have read the [Contributor
Guide](https://fesod.apache.org/community/contribution/).
- [x] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
