Github user avikganguly01 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/410#discussion_r143359090
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java
---
@@ -81,10 +80,8 @@ public SmsCampaignDropdownReadPlatformServiceImpl(final
SmsConfigUtils smsConfig
new
ParameterizedTypeReference<Collection<SmsProviderData>>() {});
smsProviderOptions = responseOne.getBody();
if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
- throw new ConnectionFailureException(hostName);
}
} catch (Exception e) {
- throw new ConnectionFailureException(hostName);
--- End diff --
Swallowing exception. Please check if it's intentional.
---
