Github user avikganguly01 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/419#discussion_r147694537
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/data/SmsCampaignData.java
---
@@ -44,6 +44,8 @@
private final DateTime recurrenceStartDate;
private final String recurrence;
private final Long providerId;
+ private final boolean isNotification;
+
--- End diff --
I would have preferred abstraction of CampaignData to SmsCampaignData and
NotificationCampaignData in case it diverges further but it's ok for now.
---