viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ URL: https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-380044778 Hi Myrtle, Regarding your DiscoveryClient comment, I have seen it. The reason, I have introduced application.yml in demo-server with EurekaRegistration turned off, to really address exceptions seen in demo-server that I noted in my above comment. It is to address that and DiscoveryClient checks were retained in my PR as is. From I have tested, EurekaRegistration need not be done in demo-server but still you could Autowire/use DiscoveryClient to check if other services are up. Someone can verify if the exceptions that I noted above are seen or not. Also, when this is deployed in a VM, it gives a common deployed environment to check on these. For now, my Eureka exception related comments can be parked and monitored. On the ClassRule suggestions and changes, I am not sure if utilizing Junit to launch services is really a good practice. Junit is largely for testing purposes. Although demo-server is not for production deployment (my hope is this :-) ), it still looks awkward to utilize it for demo-server. I was really questioning defining standard practice surrounding a technology which probably does not fit in this case. In any case, if you have already done change in fineract-cn-test, I assume that I need to pull that and make minor changes in demo-server to adopt it, test and update this PR for merge. Is my understanding correct?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
