myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm going to number my comments so that you can reference the comments when responding: 1.) You need to run the rat tests. At least three files are missing their headers, and there may be other problems. To do this run: ./gradlew rat 2.) You need to run your tests. SMSConfigurationTest doesn't compile. TestEmailService doesn't pass. TestSMSService doesn't pass. All tests should compile and run. 3.) What is the purpose of the Event domain object? <still adding points, I'll remove this tag when I'm done>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services