ShruthiRajaram commented on issue #454: FINERACT-623 - Restriction of product 
mix fix
URL: https://github.com/apache/fineract/pull/454#issuecomment-416833518
 
 
   @MexinaD  I think there is a little confusion over my last comment. I was 
completely fine with validation during disbursal and submission. All I wanted 
to convey was, change the method signature of "checkForProductMixRestrictions" 
and "checkForProductMixRestrictions" present in 
LoanWritePlatformServiceJpaRepositoryImpl, so that you can have a common method 
and call it from  "LoanApplicationWritePlatformServiceJpaRepositoryImpl" and 
"LoanWritePlatformServiceJpaRepositoryImpl". So that you handle all the 
scenarios you described previously. I believe the current change checks only 
during submission. If you want to check only during the submission and not 
during disbursal for existing loans, let me know I will approve the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to