therajanmaurya commented on a change in pull request #35: style: Removed
Hardcoded strings
URL: https://github.com/apache/fineract-cn-mobile/pull/35#discussion_r252977424
##########
File path: app/src/main/res/layout/layout_nav_header.xml
##########
@@ -24,7 +24,7 @@
android:layout_height="wrap_content"
android:layout_width="match_parent"
android:paddingTop="@dimen/nav_header_vertical_spacing"
- android:text="Rajan Maurya"
+ android:text="@string/rajan_maurya"
Review comment:
Here should not be my name and email, we will show logged in user name and
email. Please make string with name `username = Username` and `email = Email`
and change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
