vorburger commented on issue #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#issuecomment-460289123 @wkk91193 thank you very much for your interest in and contribution to Fineract/Mifos! I'm an (old) volunteer who got reminded of Mifos/Fineract this week-end at the FOSDEM conference, and I'm taking a moment to help the project clean up some of it's old issues and pull requests etc. We were wondering whether you are still alive, and would be willing to `git rebase develop` this PR and take any previous review feedback into account? If we don't hear from you within 2 weeks, we will take the liberty to close this PR without merging it, to avoid confusion for future new contributors looking at this repository - hope you understand and that's fair. From an only (very) quick look I had at this one, it LGTM, but in ideal world there would be a test contributed as part of this change which would assert that this compression filter actually does what you want it to... I don't know if you would consider taking the time to add such a test? /Cc FYI @apache/fineract-committers
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
