vorburger commented on a change in pull request #464: FINERACT-428
Parallelization of Jobs :Parallelizing and paging of update loan summary
URL: https://github.com/apache/fineract/pull/464#discussion_r253845875
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
##########
@@ -443,43 +466,109 @@ public void updateTrialBalanceDetails() throws
JobExecutionException {
.append("from acc_gl_journal_entry je WHERE
je.transaction_date = ? ")
.append("group by je.account_id, je.office_id,
je.transaction_date, Date(je.entry_date)");
- final int result = jdbcTemplate.update(sqlBuilder.toString(), new
Object[] {
+ final int result = jdbcTemplate.update(sqlBuilder.toString(), new
Object[]{
Review comment:
There are a number of formatting only and lower case to uppercase changes
proposed here which make this PR harder to review than it would be if it
consistet only of additional new functional code? Would you consider to propose
these formatting only and lower case to uppercase changes in a separate PR
instead, and undo them from here? Just asking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
