wkk91193 commented on a change in pull request #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans URL: https://github.com/apache/fineract/pull/524#discussion_r257666501
########## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/domain/JobParameter.java ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.infrastructure.jobs.domain; + +import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom; + +import javax.persistence.Column; +import javax.persistence.Entity; +import javax.persistence.Table; + +@Entity +@Table(name = "job_parameters") +public class JobParameter extends AbstractPersistableCustom<Long> { + + @Column(name = "job_id", nullable = false) + private Long jobId; + + @Column(name = "parameter_name",nullable = true) + private String parameterName; + + @Column(name = "parameter_value",nullable = true) + private String parameterValue; + + + public JobParameter(final Long jobId, final String parameterName, final String parameterValue) { + this.jobId = jobId; + this.parameterName = parameterName; + this.parameterValue = parameterValue; + } + + public static JobParameter getInstance(final Long jobId, final String parameterName, final String parameterValue){ Review comment: @vorburger using getInstance() method I'm reusing the logic of instantiating job parameter instance. Shall we keep this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
