vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change
assignment staff to groups and clients in center.
URL: https://github.com/apache/fineract/pull/514#discussion_r261844448
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -247,9 +247,15 @@ public CommandProcessingResult createClient(final
JsonCommand command) {
}
Staff staff = null;
- final Long staffId =
command.longValueOfParameterNamed(ClientApiConstants.staffIdParamName);
- if (staffId != null) {
- staff =
this.staffRepository.findByOfficeHierarchyWithNotFoundDetection(staffId,
clientOffice.getHierarchy());
+ if (clientParentGroup != null) {
+ if (clientParentGroup.getParent() != null) {
+ staff = clientParentGroup.getParent().getStaff();
+ }
+ } else {
+ final Long staffId =
command.longValueOfParameterNamed(ClientApiConstants.staffIdParamName);
Review comment:
Please add an integration test case which validates the functional changes
made
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
