vishwasbabu commented on a change in pull request #465: Fineract 614: Rates
module
URL: https://github.com/apache/fineract/pull/465#discussion_r263869893
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
##########
@@ -154,6 +157,7 @@ public String retrieveTransaction(@PathParam("loanId")
@ApiParam(value = "loanId
this.context.authenticatedUser().validateHasReadPermission(this.resourceNameForPermissions);
LoanTransactionData transactionData =
this.loanReadPlatformService.retrieveLoanTransaction(loanId, transactionId);
+
transactionData.setLoanChargePaidByList(this.loanChargePaidByReadPlatformService.getLoanChargesPaidByTransactionId(transactionId));
Review comment:
@angelboxes : Are these changes required as a part of the predefined Nominal
interest rates functionality? I would assume that LoanChargePaid by shouldn't
be related to Interest rates. I will mark all other such occurrences with the
comment "here too" .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
