vorburger commented on a change in pull request #525: FINERACT-700: upgrade
Gradle from 2.10 to 5.2.1
URL: https://github.com/apache/fineract/pull/525#discussion_r265496890
##########
File path: fineract-provider/build.gradle
##########
@@ -364,7 +363,7 @@ task integrationTest(type:Test){
tomcatRunWar.daemon = true
tomcatRunWar.execute()
Review comment:
> pulled this in and switched to a new branch. So i can work on this
@muarachmann if it's possible to raise small incremental PRs, e.g. first
doing some SQL migrations, if they are backwards compatible, it makes it easier
for other people to review smaller changes and merge them gradually.
> choose between mysql and mariadb jdbc drivers
IMHO we should use the [MariaDB JDBC
Driver](https://mariadb.com/kb/en/library/about-mariadb-connector-j/), not the
(Oracle..) MySQL driver. I know less about Drizzle, but thought that it was
abandoned; note drizzle.org is dead & last org.drizzle.jdbc:drizzle-jdbc
released in Aug, 2016, so I would ignore that. Again as I said above, it may be
best to do this in separate gradual incremental Pull Requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
