avikganguly01 commented on a change in pull request #450: Adding a compress 
response filter,registering filter
URL: https://github.com/apache/fineract/pull/450#discussion_r265650964
 
 

 ##########
 File path: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/WebXmlConfiguration.java
 ##########
 @@ -63,6 +64,8 @@ public ServletRegistrationBean jersey() {
         
jerseyServletRegistration.addInitParameter("com.sun.jersey.spi.container.ContainerResponseFilters",
                 ResponseCorsFilter.class.getName());
         
jerseyServletRegistration.addInitParameter("com.sun.jersey.config.feature.DisableWADL",
 "true");
+        
jerseyServletRegistration.addInitParameter("com.sun.jersey.spi.container.ContainerResponseFilters",
+                ResponseCompressFilter.class.getName());
 
 Review comment:
   Compression has overhead when applied indiscriminately.  
   
   This leaves it to the field force application developer to request the 
response to be compressed based on discretion. Ex :- Two GET client/{clientId} 
is not distinguishable from each other based on channel type in Fineract so 
this is a soft workaround. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to