DylanRobson opened a new pull request #574: FINERACT-609 Group Topup Loan Bug Fix. URL: https://github.com/apache/fineract/pull/574 Fix FINERACT-609 issue where topup loan wasn't working for group loan accounts. This was because the server wasn't sending the JSON array (named activeClientLoanOptions) which contained the IDs of active group loan accounts that could be closed in order to create the topup group loan account. Now when creating a group topup loan, the server correctly replies with active group loans (named activeClientLoanOptions) so that an account to close can be selected in order to create the new group topup loan account. ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket Added query: retrieveGroupActiveLoanAccountSummary(Long groupId) to get the active group loans (that can be closed) in order to complete the group topup loan application. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [x] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. I don't think any update is required. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. I'm creating this PR as advised by my GSoC mentors to see whether the integration tests on Travis-CI succeed. Even my local upstream/develop branch has failing integration tests - possibly due to https://issues.apache.org/jira/browse/FINERACT-707 - [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
