awasum commented on a change in pull request #11: Thymeleaf templating for Email
URL: 
https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291150077
 
 

 ##########
 File path: 
component-test/src/main/java/org/apache/fineract/cn/notification/TestEmailService.java
 ##########
 @@ -63,9 +67,42 @@ public void shouldSendAnEmail() throws 
InterruptedException, IOException {
                
                notificationService.sendEmail(
                                TEST_ADDRESS,
-                               "sample",
-                               null
-                               );
+                               TEST_TEMPLATE,
+                               null);
+               
Assert.assertTrue(this.eventRecorder.wait(NotificationEventConstants.POST_SEND_EMAIL_NOTIFICATION,TEST_ADDRESS
 ));
+       }
+       
+       @Test
+       public void shouldSendFormattedEmail() throws InterruptedException, 
IOException {
+               this.logger.info("Send Email Notification");
+               final TemplateImporter importer = new 
TemplateImporter(testSubject, logger);
+               final URL uri = 
ClassLoader.getSystemResource("importdata/test-templates.csv");
+               importer.importCSV(uri);
+               
+               
//Assert.assertTrue(eventRecorder.wait(NotificationEventConstants.POST_TEMPLATE,
 "sample"));
 
 Review comment:
   Could it be that the string POST_TEMPLATE is different from TEST_TEMPLATE as 
seen here: 
https://github.com/apache/fineract-cn-notifications/pull/11/commits/13a1f550593b36b72714433d45e431781e83e7eb#diff-a12daa61e90610327511e6d653c3ea61R57

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to