vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761) URL: https://github.com/apache/fineract/pull/582#issuecomment-501226724 > I see what is ongoing i too switched to mysql-connector which worked but due to the license stuff and legal stuff jdbc had to be patched somehow. If you have the time, I'd love to learn more and hear details... don't see an obvious error [in its raw build log](https://api.travis-ci.org/v3/job/544611583/log.txt) - if you do, and can point to (copy/paste) it, and how you think it can be solved, that would be very interesting. > If the LEGAL stuff can be handle by the legal team as you mentioned on JIRA it would be cool I think in https://issues.apache.org/jira/browse/LEGAL-462 we are converging on that it's OK to use the the MariaDB.org (not Oracle's MySQL) Connector/J JDBC driver instead of Drizzle at build time for Flyway, so let's assume that's a Go and get this PR to pass? Alternatively you could also pick up your work in #550 if you want to rebase it on my rebased #525. But I think it may be easier to do this as two completely separate steps - let us FIRST have a PR, this or one from you, which ONLY switches to use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761), but does not do the Gradle etc. upgrade, yet. Once that works, let us then rebase #525 and finish that off. Sounds like a plan? Can you help with the first step? > @vorburger reference to the drizzle driver is thrown quite a number of places beyond build.gradle. I found it in xml and .java files. Had to do quite a bit of find and replace to get rid of it completely. Careful - my understanding of the legal situation is that it IS OK to switch to use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver during build for Flyway, but that we do not want do, have to or legally easily can find and replace to get rid of it completely elsewhere. Having this mix should be fine, I think.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
