conradsp commented on a change in pull request #593: Create one-touch deploy 
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r296259681
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -0,0 +1,20 @@
+FROM bitnami/tomcat:7.0.94 as fineract
+
+USER root
+RUN apt-get update -qq && apt-get install -y git openjdk-8-jdk wget
+ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/jre
+
+RUN mkdir fineract
+COPY . fineract
+
+WORKDIR fineract
+RUN sed -i 's/localhost/fineractmysql/' ./fineract-provider/build.gradle
 
 Review comment:
   In build.gradle, we expect mysql to be running on localhost (I am glad that 
this is going away with your changes). In the docker-compose environment, the 
mysql instance can be referenced using the hostname 'fineractmysql'. So, simply 
replacing that so Flyway can find the DB server.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to