awasum commented on issue #614: Stop creating unnecessary overdue charge when 
amount is 0.
URL: https://github.com/apache/fineract/pull/614#issuecomment-508933358
 
 
   @mohitsinha It will be helpful to take sometime and add tests for the 
feature you provided. If there is no test for that module, then its recommended 
to invest some time and put tests for maintenance purposes.
   
   Imagine the next person who works on this particular file or feature type 
also does not write a test, it means over time, we will keep merging without 
tests. This can create a situation where we are creating features without test 
all because.. "it works manually".  Set the foundation so your future should be 
easy to manage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to