mohitsinha commented on a change in pull request #614: Stop creating
unnecessary overdue charge when amount is 0.
URL: https://github.com/apache/fineract/pull/614#discussion_r301440308
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTestResults.java
##########
@@ -724,6 +724,59 @@ public void testApplyPenaltyForOverdueLoansJobOutcome()
throws InterruptedExcept
}
+ @Test
+ public void
testAvoidUnncessaryPenaltyWhenAmountZeroForOverdueLoansJobOutcome() throws
InterruptedException {
Review comment:
I can throw some light into this.
It is creating a loan with a very small interest rate 0.000001%.
It is verifying that the `totalChargesDue` is 0 for the loan ( which is also
the feature currently as 0+ 0 + 0 is 0).
I am then calling the api `/loans/{id}?associations=charges` and then
verifying that there are no charges created for this loan. This actually tests
correctly what I have done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
