lingocoder edited a comment on issue #609: require Java 11
URL: https://github.com/apache/fineract/pull/609#issuecomment-509612834
 
 
   > (although strangely I didn't run into that issue; curious)
   
   Hey @vorburger. Are you referring to the *`:enhance`* issue? Or the 
*`:metamodel`* issue? Apologies for the confusion between the two. 
   
   The *`:enhance`* issue that I referred to 
[*here*](https://github.com/vorburger/fineract/pull/1#issuecomment-509453457) 
and the *`:metamodel`* issue that I referred to 
[*here*](https://github.com/radcortez/openjpa-gradle-plugin/issues/8#issue-464995001),
 are separate issues — *though on the same plugin* — discovered under separate 
scenarios. It is very likely, I suspect, that the two issues are related 
somehow.
   
   I discovered the *`:enhance`* issue immediately after I cloned the fineract 
project. The very first thing I did as a sanity check, was run *`gradle check`* 
on the project. That failed, [*producing this stack 
trace*](http://bit.ly/RadCrtzNhnc). However, I proceeded with 
[*my`api/implementation` changes*](http://bit.ly/FinerPR1) regardless, by 
working around that. I simply excluded the problematic task with *`gradle -x 
:enhance ...`* whenever I needed to build the project.
   
   After I was finished, I was still curious why the *`:enhance`* task had 
failed. So I investigated by creating a simple, stripped-down standalone 
project that only applied the 
*`com.radcortez.gradle:openjpa-gradle-plugin:3.0.0`*. That simple project did 
not include any of the other dependencies that fineract has. 
   
   It was under that scenario that I discovered the radcortez plugin's 
*`:metamodel`* issue.  [*Here's the stack trace I 
encountered*](https://github.com/radcortez/openjpa-gradle-plugin/files/3368461/openjpa-gradle-plugin.issue.8.a.txt)
 in that scenario. 
   
   It's possible that the reason you have not encountered [*the `:metamodel` 
issue*](http://bit.ly/RadCrtz8) in the fineract project, might be because 
[*`the `:metamodel` task/extension*](http://bit.ly/RadCrtzMeta) must be 
explicitly ran/configured in order to reproduce [*the issue I 
reported*](http://bit.ly/RadCrtz8). Whereas, the *`:enhance`* task is 
automatically ran as part of any Gradle build that includes Gradle's built-in 
*`classes`* task; such as the *`gradle :check`* task.
   
   Or is it possible that some admixture of all of the dozens of different 
dependencies in the fineract project affects the behavior of the radcortez 
plugin? Could it be that some combination of direct dependencies and transitive 
dependencies in fineract are masking or eliminating the radcortez plugin issue 
for you? Or maybe I'm only seeing issues on my machine because of development 
environment-related differences? Like OS or whatever? I'm on Windows 7 
Professional 64 bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to