vorburger commented on issue #607: use openjpa (with real dependencies) instead of shaded openjpa-all URL: https://github.com/apache/fineract/pull/607#issuecomment-510087470 > @vorburger - One question - I am not sure why we still need to compile the bval bundle if it is not used anywhere in the codebase anymore. I learnt (only AFTER our related discussion over in #606 / #617) that we actually *DO* use Apache BVal, as our javax.validation implementation of choice. The point of #606 / #617 remains valid - we should not have any direct dependencies in code to BVal (only to the javax.validation API), but we do need it at runtime. [FINERACT-777](https://issues.apache.org/jira/browse/FINERACT-777) will make this clearer. Without the Apache BVal dependency, Spring Boot start-up fails, complaining that there is no implementation for the javax.validation API available on the classpath. With this PR, that now becomes a lot more explicit than this used to be (previously it was hidden away inside the openjpa-all fat über JAR, which can be confusing). I guess in theory we chould now even experiment with swapping it out against an alternative implementation (although I have no plans to do so). > Integration tests all passing locally. as well as on Travis CI (just sayin' this to make sure that you are are that when on a PR there is a green "All checks have passed: 1 successful check", as on this one here, just below of this comment, this actually 'proves' that integration tests passed, on Travis).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
