awasum commented on a change in pull request #624: use multi-stage build in Dockerfile (fixes FINERACT-771) URL: https://github.com/apache/fineract/pull/624#discussion_r306194963
########## File path: Dockerfile ########## @@ -15,24 +15,26 @@ # specific language governing permissions and limitations # under the License. # - -FROM bitnami/tomcat:7.0.94 as fineract - -USER root -RUN apt-get update -qq && apt-get install -y git openjdk-8-jdk wget -ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/jre +FROM openjdk:8 AS builder RUN mkdir fineract COPY . fineract WORKDIR fineract RUN sed -i 's/localhost/fineractmysql/' ./fineract-provider/src/main/resources/sql/migrations/list_db/V1__mifos-platform-shared-tenants.sql RUN ./gradlew clean war -RUN mv build/libs/fineract-provider.war /opt/bitnami/tomcat/webapps + + +FROM bitnami/tomcat:7.0.94 as fineract + +USER root +RUN apt-get update -qq && apt-get install -y git openjdk-8-jdk wget Review comment: My bad...did not see the second commit..even as you highlighted in your message. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
