This is an automated email from the ASF dual-hosted git repository.

angeh pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 9d9ccfc  Update Dockerfile to use user-provided MySQL IP
     new 3d111b4  Merge pull request #625 from Anh3h/docker-updates
9d9ccfc is described below

commit 9d9ccfc76b271c34c21f3cc0b9366391a93677a5
Author: Anh3h <[email protected]>
AuthorDate: Mon Jul 29 10:23:27 2019 -0400

    Update Dockerfile to use user-provided MySQL IP
---
 Dockerfile |  5 ++++-
 README.md  | 16 ++++++++++++----
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 77f01dc..b5406df 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -21,13 +21,15 @@ RUN mkdir fineract
 COPY . fineract
 
 WORKDIR fineract
-RUN sed -i 's/localhost/fineractmysql/' 
./fineract-provider/src/main/resources/sql/migrations/list_db/V1__mifos-platform-shared-tenants.sql
+ARG mysqlserver=fineractmysql
+RUN sed -i "s/localhost/${mysqlserver}/" 
./fineract-provider/src/main/resources/sql/migrations/list_db/V1__mifos-platform-shared-tenants.sql
 RUN ./gradlew clean war
 
 
 FROM bitnami/tomcat:7.0.94 as fineract
 
 USER root
+ARG mysqlserver=fineractmysql
 RUN apt-get update -qq && apt-get install -y wget
 ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/jre
 
@@ -35,6 +37,7 @@ COPY --from=builder 
/fineract/build/libs/fineract-provider.war /opt/bitnami/tomc
 
 RUN keytool -genkey -keyalg RSA -alias tomcat -keystore 
/opt/bitnami/tomcat/tomcat.keystore -keypass xyz123 -storepass xyz123 -noprompt 
-dname "CN=Fineract, OU=Fineract, O=Fineract, L=Unknown, ST=Unknown, C=Unknown"
 COPY ./docker/server.xml /opt/bitnami/tomcat/conf
+RUN sed -i "s/fineractmysql/${mysqlserver}/" 
/opt/bitnami/tomcat/conf/server.xml
 RUN chmod 664 /opt/bitnami/tomcat/conf/server.xml
 WORKDIR /opt/bitnami/tomcat/lib
 RUN wget 
http://central.maven.org/maven2/org/drizzle/jdbc/drizzle-jdbc/1.4/drizzle-jdbc-1.4.jar
diff --git a/README.md b/README.md
index 08c903a..8c2e88f 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 Apache Fineract: A Platform for Microfinance [![Build 
Status](https://travis-ci.org/apache/fineract.svg?branch=develop)](https://travis-ci.org/apache/fineract)
  [![Docker 
Hub](https://img.shields.io/docker/pulls/apache/fineract.svg)](https://hub.docker.com/r/apache/fineract)
  [![Docker 
Build](https://img.shields.io/docker/cloud/build/apache/fineract.svg)](https://hub.docker.com/r/apache/fineract/builds)
 ============
-Fineract is a mature platform with open APIs that provides a reliable, robust, 
and affordable core banking solution for financial institutions offering 
services to the world’s 2 billion underbanked and unbanked. 
+Fineract is a mature platform with open APIs that provides a reliable, robust, 
and affordable core banking solution for financial institutions offering 
services to the world’s 2 billion underbanked and unbanked.
 
 Requirements
 ============
@@ -10,7 +10,7 @@ Requirements
 You can run the required version of the database server in a container, 
instead of having to install it, like this:
 
     docker run --name mysql-5.5 -p 3306:3306 -e MYSQL_ROOT_PASSWORD=mysql -d 
mysql:5.5
-    
+
 and stop and destroy it like this:
 
     docker rm -f mysql-5.5
@@ -52,7 +52,7 @@ Instructions to build a war file
 
 Instructions to execute Integration tests
 ============
-> Note that if this is the first time to access MySQL DB, then you may need to 
reset your password. 
+> Note that if this is the first time to access MySQL DB, then you may need to 
reset your password.
 
 Run the following commands, very similarly to how [.travis.yml](.travis.yml) 
does:
 1. `./gradlew createDB -PdbName=mifosplatform-tenants`
@@ -80,6 +80,14 @@ The [`docker-compose.yml`](docker-compose.yml) will build 
the `fineract` contain
 
 https://hub.docker.com/r/apache/fineract has a pre-built container of this 
project, built continously.
 
+You can use a MySQL database from a different or remote server by passing the 
server's IP address to the docker finerect buid process like this:
+
+    `docker build --build-arg mysqlserver=<MySQL server IP> -t fineract:latest 
.`
+
+The run it:
+
+    `docker run -d fineract:latest`
+
 Version
 ============
 
@@ -111,7 +119,7 @@ Online Demos
 ============
 
 * [Community App](https://demo.openmf.org "Reference Client App")
-> For this demo, a demo account is also provided for users to experience the 
functionality of this Community App. Users can use "mifos" for USERNAME and 
"password" for PASSWORD(without quotation marks). 
+> For this demo, a demo account is also provided for users to experience the 
functionality of this Community App. Users can use "mifos" for USERNAME and 
"password" for PASSWORD(without quotation marks).
 
 Developers
 ============

Reply via email to