kangbreder commented on issue #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#issuecomment-524739035 Okay. I will consider that and let you know. On Mon, Aug 26, 2019 at 6:44 AM Sanyam Goel <[email protected]> wrote: > Adding Authentication and common params for swagger documentation to each > and every endpoint(API's ) is unnecessary and is not a good coding standard. > It will increase redundant code for auth to every API's, which can be done > by sharing a common resource to all the API's > > In the review of removing Auth params from every API in your commit: > kangbreder@7418ac4#commitcomment-34794554 > <https://github.com/kangbreder/fineract/commit/7418ac403e4e145c86dd826086a2799dd5c4bf7c#commitcomment-34794554> > > Here are some reference links which you can refer to remove those params! > > https://stackoverflow.com/questions/47627469/swagger2-too-many-the-same-annotations > > https://stackoverflow.com/questions/39853217/swagger-how-to-combine-shared-information-from-different-apis > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/629?email_source=notifications&email_token=AJOPQRCXQ3APLX4MAREQZSDQGNUT5A5CNFSM4IPIBQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DKNRQ#issuecomment-524723910>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJOPQRBVQEUR6IRH4SBEE7LQGNUT5ANCNFSM4IPIBQPA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
