vorburger commented on issue #638: Added modifications to allow MySQL 8 compatibility (tested on MySQL… URL: https://github.com/apache/fineract/pull/638#issuecomment-538777936 This PR as-is currently seems to fail a number of integration tests in the build. While that could perhaps be fixed, the bigger problem here is the switch from the `org.drizzle.jdbc.DrizzleDriver` to the `com.mysql.jdbc.Driver` ... while that would be nice, there has been pushback in the past, because ASF hosted projects can, apparently, not distribute the LGPL licensed `com.mysql.jdbc.Driver`... is switching this a must have to allow MySQL 8 compatibility? If that's just something you "also did" as part of this PR, it would be much better if you could remove those changes again, and only do the minimum necessary to make it work with MySQL 8 ... the best way to "prove" that it does would be to include a change to the https://github.com/apache/fineract/blob/develop/.travis.yml to make it use a newer version of the mysql service.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
