ivan333m commented on a change in pull request #642: FINERACT-724 Upgrade 
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r335317127
 
 

 ##########
 File path: fineract-provider/dependencies.gradle
 ##########
 @@ -66,7 +66,7 @@ dependencies {
 
                 //[group: 'mysql', name: 'mysql-connector-java', version: 
'5.1.27'],
                 [group: 'org.drizzle.jdbc', name: 'drizzle-jdbc', version: 
'1.4'],
-               // [group: 'org.apache.tomcat', name: 'tomcat-jdbc', version: 
tomcatVersion],
+                [group: 'org.apache.tomcat', name: 'tomcat-jdbc', version: 
tomcatVersion],
 
 Review comment:
   New version of spring-boot-starter-data-jpa uses HikariCP as default 
connection pool instead of tomcat-jdbc. So I need to add this dependency. Also 
I have excluded HikariCP in the latest commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to