ivan333m commented on a change in pull request #642: FINERACT-724 Upgrade
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r335330325
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java
##########
@@ -285,9 +285,9 @@ public void getDeliveryReports() {
if (!smsMessageDeliveryReportData.getHasError()
&& (deliveryStatus != 100)) {
- SmsMessage smsMessage =
this.smsMessageRepository.findOne(smsMessageDeliveryReportData.getId());
- Integer statusType = smsMessage.getStatusType();
- boolean statusChanged = false;
+ SmsMessage smsMessage =
this.smsMessageRepository.findById(smsMessageDeliveryReportData.getId()).orElse(null);
+ Integer statusType;
Review comment:
It is redundant due to `default: statusType = smsMessage.getStatusType();`.
But I rallback my changes, probably it will be more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
