awasum commented on issue #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version URL: https://github.com/apache/fineract/pull/642#issuecomment-557500982 > @ivan333m again I want to thank you for this contribution - this is incredible work! > > I've now done a fairly detailed code review, and think this looks great, from my side. I did have a few minor suggestions and questions which perhaps you would like to take into account. > > I'm also hoping that we get a few more eyes from the community to review this - let's see. I have done a quick review of this PR. It looks good to me. I have connected this upgraded backend with mifos community app and tested that login works. Most major CRUD operation works as far as I can tell. I have not done a security audit to see how the upgrades affects security. We can do that later. @vorburger I wont know if this resolves the conversation for you as your review here is the only red flag preventing me from merging this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
