awasum commented on issue #653: FINERACT-724: upgrade Spring boot to 2.1.7 
URL: https://github.com/apache/fineract/pull/653#issuecomment-557894154
 
 
   > I have downloaded logs from two builds (with and without upgrade changes).
   > Spring Boot :: (v1.2.8.RELEASE) 
https://api.travis-ci.org/v3/job/599081380/log.txt
   > Spring Boot :: (v2.1.9.RELEASE) 
https://api.travis-ci.org/v3/job/616120017/log.txt
   > 
   > I used following `grep` command for the analysis:
   > `grep -o -E "(DEBUG|INFO|WARN|TRACE) ........\S*" ./log_old.txt | sort | 
uniq -c | sort -n`
   > 
   > I had following results:
   > With upgrade:
   > 
   > ```
   >      ...
   >      34 INFO  o.s.s.quartz.SchedulerFactoryBean
   >      81 DEBUG o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl
   >     102 INFO  org.quartz.impl.StdSchedulerFactory
   >     238 INFO  org.quartz.core.QuartzScheduler
   >     350 INFO  o.a.f.c.p.CommandHandlerProvider
   >     374 INFO  c.g.flyway.core.command.DbMigrate
   >     630 INFO   [Daemon
   >    1260 INFO   [Execution
   >    4781 INFO  o.s.b.a.audit.listener.AuditListener
   >    5111 INFO  o.a.f.i.s.f.TenantAwareBasicAuthenticationFilter
   > ```
   > 
   > Without upgrade:
   > 
   > ```
   >      ...
   >      37 INFO  o.s.s.quartz.SchedulerFactoryBean
   >      81 DEBUG o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl
   >     105 INFO  org.quartz.impl.StdSchedulerFactory
   >     250 INFO  org.quartz.core.QuartzScheduler
   >     350 INFO  o.a.f.c.p.CommandHandlerProvider
   >     375 INFO  c.g.flyway.core.command.DbMigrate
   >    1260 INFO   [Daemon
   >    1260 INFO   [Execution
   >    4755 DEBUG o.s.b.a.audit.listener.AuditListener
   >    5085 INFO  o.a.f.i.s.f.TenantAwareBasicAuthenticationFilter 
   > ```
   > 
   > At the same time I did not found large diff messages with Exceptions:
   > 
   > > grep -E -o "Exception..................\S* " ./log_old.txt | sort | uniq 
-c | sort -n
   > 
   > ```
   >       1 Exception, class 
org.apache.fineract.infrastructure.campaigns.sms.domain.SmsCampaignStatusEnumerations,
 
   >       1 Exception, class 
org.apache.fineract.portfolio.savings.domain.SavingsEvent, 
   >       1 Exception, class 
org.apache.fineract.useradministration.domain.AppUserRepositoryWrapper, 
   >       1 ExceptionIfPossible(EntityManagerFactoryUtils.java:407) 
   >       1 ExceptionTranslationFilter]; 
   >       1 ExceptionTranslationFilter@1b7baa1, 
   >       2 Exception: Account not found 
   >       3 ExceptionIfPossible(EntityManagerFactoryUtils.java:415) 
   >       4 Exception(BrokerImpl.java:2363) 
   >       4 Exception(BrokerImpl.java:2374) 
   >       4 Exception(DBDictionary.java:4963) 
   >       4 Exception: Duplicate entry '50-MSISDN' 
   >       4 ExceptionIfPossible(EntityManagerFactoryUtils.java:404) 
   >       4 Exceptions.getStore(SQLExceptions.java:133) 
   >       4 Exceptions.getStore(SQLExceptions.java:75) 
   >       7 ExceptionIfPossible(AbstractEntityManagerFactoryBean.java:417) 
   >       7 
ExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:136)
 
   >       7 
ExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:147)
 
   >       7 
ExceptionTranslator.translateExceptionIfPossible(ChainedPersistenceExceptionTranslator.java:59)
 
   >       8 Exception: An optimistic lock 
   >       8 ExceptionIfPossible(DefaultJpaDialect.java:122) 
   >       9 Exception could not be mapped 
   >       9 
ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113) 
   >      12 Exception: Deadlock found when 
   >      28 Exception: Optimistic locking 
   >      28 Exception: The transaction has 
   > ```
   > 
   > > grep -E -o "Exception..................\S* " ./log_new.txt | sort | uniq 
-c | sort -n
   > 
   > ```
   >       1 Exception, class 
org.apache.fineract.infrastructure.campaigns.email.domain.EmailMessageAssembler,
 
   >       1 Exception, class 
org.apache.fineract.portfolio.calendar.domain.CalendarRemindBy, 
   >       1 Exception, class 
org.apache.fineract.portfolio.client.domain.ClientTransactionRepositoryWrapper, 
   >       1 Exception, class 
org.apache.fineract.portfolio.note.domain.NoteType, 
   >       1 ExceptionTranslationFilter]; 
   >       1 ExceptionTranslationFilter@25e03459, 
   >       4 Exception: Duplicate entry '50-MSISDN' 
   >       8 Exception: An optimistic lock 
   >      10 Exception could not be mapped 
   >      16 Exception: Deadlock found when 
   >      28 Exception: Optimistic locking 
   >      35 Exception: The transaction has 
   > ```
   > 
   > So as we can see there is no dramatic changes in the numbers.
   > Log before upgrade is about 4.2 MB, it is very close to the limit (As I 
understand limit is about 4 - 4.5 MB).
   > I would propose to increase limit to 5 MB.
   
   Is there a way to increase log size on Travis free version? I have not been 
able to find it. 
   
   Also there is the typical 50 minutes timeout for Travis free version. If our 
build runs for more than 50 minutes..then everything fails as Travis will run 
into a timeout. See here: 
https://docs.travis-ci.com/user/customizing-the-build/#build-timeouts
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to