xurror opened a new pull request #662: FINERACT-797: Use Spring Boot BOM to 
avoid maintaining version numbers in dependencies.gradle
URL: https://github.com/apache/fineract/pull/662
 
 
   FINERACT-797 - Spring Dependency Management
    - Update mockito to latest version
    - Move dependencies from dependencies.gradle to build.gradle
    - Removed implemented TODOs from XBRBuilderTest.java
   https://issues.apache.org/jira/browse/FINERACT-797
   
   ## Description
   In an ideal world, in a future PR, it would be really really cool if we 
could just avoid having to repeat using fixed version, and could use the 
implicit versions via Spring BOM dependency management, see 
https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#managing-dependencies
 ...
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Commit message starts with the issue number from 
https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have 
been followed.
   
   - [ ] API documentation at 
https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been 
updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes 
made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to