xurror commented on a change in pull request #662: FINERACT-797: Use Spring 
Boot BOM to avoid maintaining version numbers in dependencies.gradle
URL: https://github.com/apache/fineract/pull/662#discussion_r352316208
 
 

 ##########
 File path: fineract-provider/build.gradle
 ##########
 @@ -59,9 +61,83 @@ apply plugin: 'com.bmuschko.tomcat'
 apply plugin: 'project-report'
 apply plugin: 'java'
 apply plugin: 'openjpa'
+
 // apply plugin: 'pmd'
 // apply plugin: 'findbugs'
 
+dependencyManagement {
+  imports {
+    mavenBom 'org.springframework:spring-framework-bom:5.1.10.RELEASE'
+  }
+  dependencies {
 
 Review comment:
   Well, the spring framework-bom resolves all spring artifacts(like 
spring-core etc) without explicitly declaring them since they all use thesame 
version
   
   It seems there is no spring-boot-bom to handle the spring boot artifacts and 
dependencies

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to