xurror commented on issue #662: FINERACT-797: Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle URL: https://github.com/apache/fineract/pull/662#issuecomment-560164958 > @xurror Nice changes, thanks. > > All points described bellow are OPTIONAL! > > I would propose following: > > 1. According to the spring doc [spring doc](https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/) > `When you apply the io.spring.dependency-management plugin, Spring Boot’s plugin will automatically import the spring-boot-dependencies bom from the version of Spring Boot that you are using....`. So you don't need to specify version on spring boot `dependencySet` > 2. As I know when you apply bom it controls all third-party dependencies that declared it the bom. Here is a [spring boot bom](https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-dependencies/pom.xml). You can find spring and all related third-party dependencies there. Therefore we could exclude spring framework version and alot of third-party. > > You could generate spring boot application on Spring IO initializer and use it as an example. Thanks for this review, the new updates I have made should fix that
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
