vorburger commented on issue #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues URL: https://github.com/apache/fineract/pull/670#issuecomment-565724729 > Looks..like the ShareAccount Integration tests are failing(locally) Oh! Silly me, I had not even noticed that (which is why I, confusingly, wrote about Docker above). How about #675 to make this more obvious in the future? Both for stupid myself :smiling_imp: and others.. > Anyone reading this who could help pinpoint the problem before me..that will be great. See if any of the review comments I just posted (before reading this) may actually help to fix this? > Last resort, I will revert the changes in the share account module and add one change at a time while run the integration tests till we get it. Yeah, I was thinking of suggesting doing some of the changes proposed here individually, but then didn't want to bother you with extra work. Especially those I picked up on, perhaps easier to get more eyes on them if smaller changes? Up to you.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
