vorburger commented on issue #682: use SpotBugs and fix over 300 high priority Rule Violations (FINERACT-702) URL: https://github.com/apache/fineract/pull/682#issuecomment-573247465 @awasum the remaining integration test failures are in `LoanReschedulingWithinCenterTest`. I noticed only now that your original PR #670 changed the expected "interest due" in that same test. You seem to have added that in your last commit re. "Fix more spotbugs failures and integration tests" in the original PR. That's... interesting, and probably merits more investigation? It looks like one of the changes we're making here for SpotBugs is causing a discrepancy. Either we found a pretty major real functional bug, or we broke the main functionality... which one is it? :question: PS: Interestingly, my PR expects a different result than yours; the original was 90.82 & 41.05, you changed it to 42.38 & 19.16, whereas my results are 84.76 & 38.31 (so closer). PPS: The "expected" and "was" in the `ComparisonFailure` is the wrong way around.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
