This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 75f7c59 add .project and .settings/ to .gitignore
new af0dd7e use SpotBugs & fix over 300 high priority rule violations
(FINERACT-702)
new 89b996c Revert changes made to LoanReschedulingWithinCenterTest
(FINERACT-702)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.travis.yml | 2 +-
fineract-provider/build.gradle | 15 ++-
fineract-provider/dependencies.gradle | 2 +-
.../integrationtests/CenterIntegrationTest.java | 27 +++--
.../ClientLoanIntegrationTest.java | 53 ++++------
.../ClientSavingsIntegrationTest.java | 64 ++++--------
...ientUndoRejectAndWithdrawalIntegrationTest.java | 37 +++----
.../fineract/integrationtests/CurrenciesTest.java | 15 ++-
.../LoanReschedulingWithinCenterTest.java | 6 +-
.../integrationtests/SchedulerJobsTestResults.java | 46 ++++----
.../integrationtests/common/CenterDomain.java | 8 +-
.../integrationtests/common/CurrenciesHelper.java | 6 +-
.../integrationtests/common/WorkingDaysHelper.java | 15 +--
.../common/accounting/GLAccountBuilder.java | 90 ++++++++--------
.../common/savings/SavingsAccountHelper.java | 28 ++---
.../savings/SavingsApplicationTestBuilder.java | 6 +-
.../shares/ShareAccountIntegrationTests.java | 24 ++---
.../shares/ShareAccountTransactionHelper.java | 7 +-
.../common/shares/ShareProductHelper.java | 17 ++-
.../accounting/common/AccountingConstants.java | 16 +--
.../accounting/glaccount/data/GLAccountData.java | 9 +-
.../accounting/glaccount/domain/TrialBalance.java | 8 +-
...EntryWritePlatformServiceJpaRepositoryImpl.java | 16 +--
.../data/ChargeToGLAccountMapper.java | 4 +-
.../data/PaymentTypeToGLAccountMapper.java | 4 +-
.../service/ProductToGLAccountMappingHelper.java | 8 +-
.../domain/LoanProductProvisioningEntry.java | 17 ++-
...ProvisioningEntriesReadPlatformServiceImpl.java | 22 ++--
.../domain/AccountNumberFormatEnumerations.java | 39 +++----
.../importhandler/center/CenterImportHandler.java | 2 +-
.../importhandler/group/GroupImportHandler.java | 3 +-
.../campaigns/email/ScheduledEmailConstants.java | 16 +--
.../EmailCampaignReadPlatformServiceImpl.java | 22 ++--
.../core/boot/ApplicationExitUtil.java | 3 +-
.../core/data/DataValidatorBuilder.java | 2 +-
.../infrastructure/core/data/EnumOptionData.java | 22 +++-
...AbandonedConnectionCleanupShutdownListener.java | 4 +-
.../fineract/infrastructure/core/service/Page.java | 3 +-
.../dataqueries/data/DatatableCheckStatusData.java | 4 +-
.../dataqueries/data/DatatableData.java | 3 +-
.../data/EntityDataTableChecksTemplateData.java | 32 +++++-
.../data/ResultsetColumnHeaderData.java | 7 +-
.../dataqueries/data/ResultsetColumnValueData.java | 4 +-
.../service/ReadWriteNonCoreDataServiceImpl.java | 34 ++----
.../entityaccess/domain/FineractEntityType.java | 19 ++--
.../fineract/infrastructure/gcm/domain/Sender.java | 75 +++----------
.../fineract/infrastructure/hooks/data/Field.java | 4 +-
.../ReportMailingJobConstants.java | 25 +++--
.../ReportMailingJobEmailAttachmentFileFormat.java | 14 +--
...ortMailingJobStretchyReportParamDateOption.java | 12 +--
.../security/api/AuthenticationApiResource.java | 6 +-
.../constants/TwoFactorConfigurationConstants.java | 17 ++-
.../interoperation/data/InteropResponseData.java | 2 +-
.../service/TopicDomainServiceImpl.java | 2 +-
.../organisation/monetary/data/CurrencyData.java | 35 ++++---
.../monetary/domain/ApplicationCurrency.java | 8 +-
.../organisation/monetary/domain/MoneyHelper.java | 11 +-
.../provisioning/domain/ProvisioningCriteria.java | 21 +---
.../service/ProvisioningCriteriaAssembler.java | 5 +-
.../organisation/staff/data/StaffData.java | 8 +-
.../organisation/teller/data/CashierData.java | 9 +-
.../organisation/teller/domain/CashierTxnType.java | 4 +-
.../TellerManagementReadPlatformServiceImpl.java | 30 +++---
.../portfolio/account/PortfolioAccountType.java | 6 +-
.../account/data/AccountTransferData.java | 9 +-
.../account/data/PortfolioAccountData.java | 7 +-
.../domain/AccountTransferStandingInstruction.java | 4 +-
.../data/ShareAccountSummaryData.java | 4 +-
.../constants/ShareAccountApiConstants.java | 35 ++++---
.../portfolio/address/data/AddressData.java | 7 +-
.../portfolio/calendar/data/CalendarData.java | 66 +++++++++++-
.../portfolio/calendar/domain/Calendar.java | 6 +-
.../fineract/portfolio/charge/domain/Charge.java | 59 ++++++-----
.../service/ChargeReadPlatformServiceImpl.java | 17 +--
.../fineract/portfolio/client/data/ClientData.java | 9 +-
.../client/data/ClientFamilyMembersData.java | 7 +-
.../portfolio/client/data/ClientNonPersonData.java | 5 +-
.../portfolio/client/data/ClientTimelineData.java | 6 +-
.../floatingrates/data/FloatingRateData.java | 7 +-
.../floatingrates/data/FloatingRatePeriodData.java | 7 +-
.../serialization/FloatingRateDataValidator.java | 27 ++---
.../fineract/portfolio/group/data/CenterData.java | 53 ++++++++--
.../portfolio/group/data/GroupGeneralData.java | 56 +++++++++-
.../portfolio/group/data/GroupRoleData.java | 20 +++-
.../portfolio/group/data/GroupSummary.java | 4 +-
.../portfolio/group/data/GroupTimelineData.java | 28 ++++-
.../group/domain/GroupRepositoryWrapper.java | 6 +-
.../portfolio/group/domain/GroupTypes.java | 2 +-
.../portfolio/group/domain/GroupingTypeStatus.java | 12 ++-
.../loanaccount/data/LoanTransactionData.java | 2 +-
.../portfolio/loanaccount/domain/Loan.java | 116 +++++++--------------
.../domain/LoanDisbursementDetails.java | 6 ++
.../loanaccount/guarantor/GuarantorConstants.java | 4 +-
.../loanaccount/guarantor/domain/Guarantor.java | 28 ++---
...ntorWritePlatformServiceJpaRepositoryIImpl.java | 20 ++--
.../service/LoanScheduleAssembler.java | 2 +-
.../RescheduleLoansApiConstants.java | 10 +-
.../LoanApplicationCommandFromApiJsonHelper.java | 2 +-
.../loanaccount/service/LoanChargeAssembler.java | 23 ++--
.../service/LoanSchedularServiceImpl.java | 11 +-
.../LoanProductBorrowerCycleVariationData.java | 7 +-
.../loanproduct/data/LoanProductData.java | 27 +++--
.../loanproduct/data/LoanProductGuaranteeData.java | 3 +-
.../data/LoanProductInterestRecalculationData.java | 10 +-
.../data/TransactionProcessingStrategyData.java | 4 +-
.../portfolio/loanproduct/domain/LoanProduct.java | 38 ++-----
.../domain/LoanProductBorrowerCycleVariations.java | 6 ++
.../domain/LoanProductConfigurableAttributes.java | 37 +++++--
.../serialization/LoanProductDataValidator.java | 6 +-
.../paymentdetail/data/PaymentDetailData.java | 25 ++++-
.../paymenttype/data/PaymentTypeData.java | 28 ++++-
.../savings/data/DepositAccountDataValidator.java | 83 +++++----------
.../SavingsAccountApplicationTimelineData.java | 4 +-
.../savings/data/SavingsAccountChargeData.java | 9 +-
.../portfolio/savings/data/SavingsAccountData.java | 10 +-
.../savings/data/SavingsAccountStatusEnumData.java | 4 +-
.../data/SavingsAccountSubStatusEnumData.java | 4 +-
.../savings/data/SavingsAccountSummaryData.java | 7 +-
.../data/SavingsAccountTransactionData.java | 9 +-
.../data/SavingsAccountTransactionEnumData.java | 4 +-
.../portfolio/savings/data/SavingsProductData.java | 13 +--
.../savings/domain/SavingsAccountCharge.java | 80 +++++++-------
...ocessWritePlatformServiceJpaRepositoryImpl.java | 42 ++------
...lfBeneficiariesTPTWritePlatformServiceImpl.java | 2 +-
.../self/loanaccount/api/SelfLoansApiResource.java | 2 +-
.../loanaccount/data/SelfLoansDataValidator.java | 8 ++
.../self/registration/SelfServiceApiConstants.java | 16 +--
.../data/ShareAccountApplicationTimelineData.java | 4 +-
.../shareaccounts/data/ShareAccountChargeData.java | 12 +--
.../shareaccounts/data/ShareAccountData.java | 12 +--
.../data/ShareAccountDividendData.java | 7 +-
.../data/ShareAccountStatusEnumData.java | 4 +-
.../data/ShareAccountTransactionData.java | 7 +-
.../data/ShareAccountTransactionEnumData.java | 4 +-
.../shareaccounts/domain/ShareAccount.java | 1 +
.../shareaccounts/domain/ShareAccountCharge.java | 14 +--
.../domain/ShareAccountTransaction.java | 16 +--
.../portfolio/tax/data/TaxComponentData.java | 3 +-
.../tax/data/TaxComponentHistoryData.java | 7 +-
.../fineract/portfolio/tax/data/TaxGroupData.java | 3 +-
.../portfolio/tax/data/TaxGroupMappingsData.java | 4 +-
...nsferWritePlatformServiceJpaRepositoryImpl.java | 29 ++----
.../template/service/TemplateMergeService.java | 44 +++-----
.../provider/CommandHandlerProviderTest.java | 2 -
.../mix/report/service/XBRLBuilderTest.java | 31 +++---
145 files changed, 1272 insertions(+), 1192 deletions(-)
