vorburger commented on issue #684:  more SpotBugs related / inspired code clean 
up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573415656
 
 
   > why `ShareAccountIntegrationTests` (only) fails on this PR
   
   specifically `testCreateShareAccountWithCharges()` in line 487 
`Assert.assertEquals("0.0", 
String.valueOf(chargeDef.get("amountOutstanding")));` ... I've manually 
reverted some of the changes of this PR to understand which one causes that 
failure, and figured it must be related to one of those `hashCode()` and 
`equals()` changes in `Charge`, `TrialBalance`, `LoanProductProvisioningEntry`, 
`LoanProductBorrowerCycleVariations` or `ShareAccountCharge`. Hm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to