vorburger commented on issue #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#issuecomment-573425706 > @vorburger Thank you. I have resolved the conflicts. following the merge of #682, there now is a new conflict again already... will you resolve, again? I think to avoid that happening again and again, we should try to get a minimal version of this PR merged ASAP, and then incrementally iterate on improving it in separate follow-up PRs. > The io.swagger.core.v3.swagger-gradle-plugin is a plugin i had added to automatically generate the specs during build time and not at run time. This was so that every time one builds on the project, the response.json updates. But this did not work as expected. I had removed the plugin from the build script. I am wondering how its still in there. probably while i have rebasing and resolving conflicts, that came back in the script. I will remove the plugin. OK, cool. From my side, we could perhaps merge this PR after you've done that (but @Sanyam96 more than me should fully review and LGTM this). > @vorburger i think you have a nice idea. Is it possible to get the file and the swagger-ui in the war? Yeah, I think it should be. @Sanyam96 can probably work with you towards that. Again, I would suggest that we get this PR to a state where it can be merged even if it can still be improved in follow-up you can raise in separate new PRs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
