vorburger commented on issue #689: introduce Checkstyle, start enforcing 
whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689#issuecomment-576035647
 
 
   @awasum FYI with me just having merged #688, this one is now ready! Would 
you do the honours of reviewing it (also to get familiar with it, in case you 
would consider make some further contributions based on this?), and merging 
ASAP?
   
   PS: This build will most likely fail, because it's Sunday, due to 
[FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820) (what a 
PITA, is anyone ever going to fix that?). Perhaps you'd like to Close and 
Re-Open it tomorrow, before merging it to convince yourself that the Checkstyle 
really fully passes? (Which it does, I've of course tested this locally.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to