This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 3a17da4 Activate and Enforce Checkstyle EqualsHashCode check. (#703)
3a17da4 is described below
commit 3a17da44dfced611faa21f1dcf0a10a094919ad8
Author: Michael Vorburger ⛑️ <[email protected]>
AuthorDate: Mon Jan 27 22:02:41 2020 +0100
Activate and Enforce Checkstyle EqualsHashCode check. (#703)
Thanks to prior work for SpotBugs, this passes without requiring any
code adjustments. (Fineract had a nubmer of problems in this space
before the SpotBugs work.)
Enabling this helps to ensure non-regression so that no new equals() and
hashCode() related bugs creep in. (This does overlap a little bit with
SpotBugs, but the build time overhead to run the extra check is
completely negligible, so it seems worth having this. If only just in
case SpotBugs for whatever reason in the future would get deactivated
again.)
---
fineract-provider/config/checkstyle/checkstyle.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fineract-provider/config/checkstyle/checkstyle.xml
b/fineract-provider/config/checkstyle/checkstyle.xml
index 9304717..956fd2e 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -48,8 +48,8 @@
</module>
-->
<module name="TreeWalker">
-<!-- TODO Enable many more checks (go about this one by one, step by step,
raise separate PRs fixing and then enforcing):
<module name="EqualsHashCode"/>
+<!-- TODO Enable many more checks (go about this one by one, step by step,
raise separate PRs fixing and then enforcing):
<module name="RedundantImport"/>
<module name="UnusedImports"/>
