vorburger commented on issue #609: [WIP] require Java 11 [WIP] URL: https://github.com/apache/fineract/pull/609#issuecomment-593087040 No, removing the Gradle wrapper is bad idea; it's useful to have the "official" (tested) version in a project, this saves many headaches. Anyone locally can still try use another Gradle version, of course. Also, this had nothing to do with Java 11 and this PR. Using gradle upgradeDependency seems interesting. But the best way to contribute to open source is not to post this as a comment on an existing PR, but to just go ahead and try it, in a small new PR, focused on changing just the minimum possible, and then evolve, step by step. If it passes the build, we'll review and merge it. Re. helping to continue the work here, I propose you start a separate PR, based on this. If it passes the build, we'll review and merge it. And you obviously cannot just disable all tests, no - that wouldn't be any fun... ;-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
